Repository navigation
feat(Agent): Support .NET11 agents - #1970
Conversation
7ed69ec to
bb6f056
Compare
CharliePoole
left a comment
There was a problem hiding this comment.
Looks perfect! Thanks a lot.
oznetmaster
left a comment
There was a problem hiding this comment.
@mikkelbu Thanks for the implementation. I found one Chocolatey packaging omission to fix before merge, described inline. The new agent selection and the other package additions look consistent with the existing targets.
I reviewed exact head bb6f056 and the successful CI run 43764875713, including the new single-.NET-11 and mixed-runtime package comparisons. Independently, the full solution builds with the .NET 11 GA SDK; the new core target passes 452 tests with one skip. Real Framework Console execution passes the selected test on .NET 11 and all four selected assembly cases in the mixed 6/8/10/11 run. The latter runs on CLR 8/8/10/11 respectively, matching the existing older-target agent mapping; it is not evidence of an actual .NET 6 worker.
The normal local Test script compiled past Cake.Git but stopped at GitVersion because this isolated worktree's shared history references a missing object. I am not claiming a successful local run of that full script or a diagnosis of your Cake.Git error. The direct build and executions above are separate evidence.
Prepared by Neil Colvin with assistance from OpenAI Codex.
| <file src = "$BIN_DIR$agents/net11.0/nunit.engine.api.xml" target="tools/agents/net11.0" /> | ||
| <file src = "$BIN_DIR$agents/net11.0/nunit.engine.core.dll" target="tools/agents/net11.0" /> | ||
| <file src = "$BIN_DIR$agents/net11.0/testcentric.engine.metadata.dll" target="tools/agents/net11.0" /> | ||
| <file src = "$BIN_DIR$agents/net11.0/Microsoft.Extensions.DependencyModel.dll" target="tools/agents/net11.0" /> |
There was a problem hiding this comment.
[P2] Include the Chocolatey marker beside the new .NET 11 agent
The new net11.0 directory does not receive VERIFICATION.txt: the marker following this block still targets net10.0. ExtensionManager.FindExtensionAssemblies(Assembly) checks beside the host assembly for this file and otherwise searches the NuGet-style NUnit.Extension.* directories rather than Chocolatey's nunit-extension-* directories. As a result, the new agent misses extensions installed through Chocolatey even though ordinary NUnit execution and the current package checks pass.
I reproduced this with the exact PR engine and its existing FakeExtensions assembly in a Chocolatey-shaped layout: without the marker, zero extensions are found; adding only VERIFICATION.txt beside the net11.0 core finds all seven fixture extensions. Please retain the net10.0 marker and add a separate entry targeting tools/agents/net11.0. A Chocolatey package-content assertion for that marker would catch this omission.
|
@oznetmaster Very well spotted. In retrospect, I could have created that check to look for VERIFICATION.txt in the parent directory, but since we're at the end of the 3.x line it's not worth it. We should look at how we do this in V4 as well. |
|
@nunit/engine-team This does not appear to be an immediate problem in V4 but may be one in the next beta. The engine looks for VERIFICATION.txt in it's own directory. If present, it means that it is executing under a runner installed from a chocolatey package. This file is required to be present in the package This check enforces a design constraint we decided upon very early in development: Runners installed from chocolatey.org only load chocolatey extensions and those installed in other ways only load standard (nuget) extensions. The different layout and naming conventions for chocolatey packages are not a design decision on our part but a requirement for publishing on chocolatey.org. If at any point, the agent itself supported extensions, then we would need to include VERIFICATION.txt somewhere in the agent directory for each extension. That's likely to happen during the next beta so I'll either add a new issue or add this as a comment to one of the existing "Support extension" issues. |
|
@oznetmaster UPDATE... |
|
@mikkelbu Knowing you're busy during the work week, I made the suggested change through the GitHub online interface. We still have an error. I think I see the cause so I'll download this and check it out. |
|
@CharliePoole Thanks; the new nuspec entry at 4232a88 addresses my net11.0 marker finding while retaining the net10.0 entry. Your updated V3/V4 distinction matches the source I reviewed. For the remaining error, the latest CI run 43944014284 stops in Package while fetching metadata for NUnit.Extension.NUnitProjectLoader 3.8.0 from the Chocolatey v2 feed, which returned HTTP 504. That log does not establish a .NET 11 agent failure. I see you are already investigating, so I will leave the source work with you and re-review the completed package/CI result afterward. Prepared jointly by Neil Colvin and OpenAI Codex. |
Fixes #1954